Repository navigation
fix(ai): handle forced tool arguments in workspace inventory - #973
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing OpenRouter support (#971). Through OpenRouter, OpenAI models fill every tool parameter, so
list_workspace_itemsreceived filters nobody asked for (taskType: "task",taskStatus: "todo",isFavorites: false,folderId: null) and returned empty or partial results. A per-folder request also produced 10 parallel tool calls in one response, which exceeded the 8-call limit and failed withinvalidResponse.isFavorites,taskTypeandtaskStatusfilters are nullable:nullor omitted means no filter.taskType/taskStatusoutside Notes returnTASK_FILTER_NOTES_ONLYwith a hint instead of an empty list.folderIdaccepts a folder ID,"inbox"for items without a folder, ornull/omitted for all folders. Other tools keepnullas root/Inbox.AI_LIMITS.toolCalls) in the SDK, Responses and chat completions paths and in the message schema.invalidResponsein the SDK path now carries a short diagnostic code (finish reason, tool call count, empty response, etc.) in the trace and under the chat error. The trace logs the final error code.