Skip to content

test(ai): cover sdk diagnostics and clarify inbox filter - #974

Merged
antonreshetov merged 1 commit into
mainfrom
fix/ai-review-followups
Oct 7, 2026
Merged

antonreshetov merged 1 commit into
mainfrom
fix/ai-review-followups

Conversation

@antonreshetov

Copy link
Copy Markdown
Member

Follow-up to review notes on #973.

  • Instructions now say that list_workspace_items uses folderId: "inbox" for the Inbox and null for all folders, since other workspace tools still use null for root/Inbox.
  • Tests for SDK diagnostics: only a safe raw finish reason reaches the diagnostic, emptyResponse:reasoningOnly, replaySchema without response content, and the trace logging the final provider error code (authentication, HTTP 401) instead of upstream.
  • The cancellation test now checks that the trace records request.cancelled and not request.error.

@antonreshetov antonreshetov self-assigned this Oct 7, 2026
@antonreshetov
antonreshetov merged commit 29596f0 into main Oct 7, 2026
@antonreshetov
antonreshetov deleted the fix/ai-review-followups branch October 7, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant