Repository navigation
Conversation
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126315162. |
Summary: Pull Request resolved: react#59220 `CoreComponentsRegistry` pulls every built-in component implementation into `fabric:jni`, preventing those components from depending on Fabric JNI without a cycle. Move the registry header and implementation into `newarchdefaults:jni`, which already owns default component registration, while preserving both public include paths. Point the registry’s other native consumers at the same shared target. Changelog: [Internal] Differential Revision: D126315162
javache
force-pushed
the
export-D126315162
branch
from
October 20, 2026 11:12
1566120 to
fd5be24
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 20, 2026
Summary: Pull Request resolved: react#59220 `CoreComponentsRegistry` pulls every built-in component implementation into `fabric:jni`, preventing those components from depending on Fabric JNI without a cycle. Move the registry header and implementation into `newarchdefaults:jni`, which already owns default component registration, while preserving both public include paths. Point the registry’s other native consumers at the same shared target. Changelog: [Internal] Differential Revision: D126315162
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 20, 2026
Summary: Pull Request resolved: react#59220 `CoreComponentsRegistry` pulls every built-in component implementation into `fabric:jni`, preventing those components from depending on Fabric JNI without a cycle. Move the registry header and implementation into `newarchdefaults:jni`, which already owns default component registration, while preserving both public include paths. Point the registry’s other native consumers at the same shared target. Changelog: [Internal] Differential Revision: D126315162
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 20, 2026
Summary: Pull Request resolved: react#59220 `CoreComponentsRegistry` pulls every built-in component implementation into `fabric:jni`, preventing those components from depending on Fabric JNI without a cycle. Move the registry header and implementation into `newarchdefaults:jni`, which already owns default component registration, while preserving both public include paths. Point the registry’s other native consumers at the same shared target. Changelog: [Internal] Differential Revision: D126315162
|
This pull request has been merged in 935b952. |
Collaborator
|
This pull request was successfully merged by @javache in 935b952 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
CoreComponentsRegistrypulls every built-in component implementation intofabric:jni, preventing those components from depending on Fabric JNI without a cycle.Move the registry header and implementation into
newarchdefaults:jni, which already owns default component registration, while preserving both public include paths. Point the registry’s other native consumers at the same shared target.Changelog: [Internal]
Differential Revision: D126315162