Skip to content

Move CoreComponentsRegistry to newarchdefaults (#59220) #59220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javache wants to merge 1 commit into from
Closed

Move CoreComponentsRegistry to newarchdefaults (#59220) #59220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-native/ReactAndroid/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,10 @@ val preparePrefab by
Pair("../ReactCommon/hermes/inspector-modern/", "hermes/inspector-modern/"),
// fabricjni
Pair("src/main/jni/react/fabric", "react/fabric/"),
Pair(
"src/main/jni/react/newarchdefaults/CoreComponentsRegistry.h",
"react/fabric/",
),
// uimanagerjni
Pair("src/main/jni/react/uimanager", "react/uimanager/"),
// glog
Expand Down
7 changes: 0 additions & 7 deletions packages/react-native/ReactAndroid/src/main/jni/react/fabric/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,8 @@ target_link_libraries(
rrc_legacyviewmanagerinterop
react_utils
reactnativejni
rrc_image
rrc_modal
rrc_progressbar
rrc_root
rrc_safeareaview
rrc_scrollview
rrc_switch
rrc_text
rrc_textinput
rrc_unimplementedview
rrc_view
yoga
Expand Down
13 changes: 13 additions & 0 deletions packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,19 @@ target_link_libraries(react_newarchdefaults
react_nativemodule_featureflags
react_nativemodule_microtasks
react_nativemodule_idlecallbacks
react_renderer_attributedstring
react_renderer_componentregistry
react_renderer_textlayoutmanager
rrc_image
rrc_modal
rrc_progressbar
rrc_safeareaview
rrc_scrollview
rrc_switch
rrc_text
rrc_textinput
rrc_unimplementedview
rrc_view
jsi)

target_compile_reactnative_options(react_newarchdefaults PRIVATE)
4 changes: 4 additions & 0 deletions ...i/react/fabric/CoreComponentsRegistry.cpp → ...ewarchdefaults/CoreComponentsRegistry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ sharedProviderRegistry() {
void addCoreComponents(
std::shared_ptr<const ComponentDescriptorProviderRegistry>
providerRegistry) {
if (providerRegistry == nullptr) {
return;
}

providerRegistry->add(
concreteComponentDescriptorProvider<
AndroidProgressBarComponentDescriptor>());
Expand Down
0 ...jni/react/fabric/CoreComponentsRegistry.h → .../newarchdefaults/CoreComponentsRegistry.h
View file
Open in desktop
File renamed without changes.
Loading