Repository navigation
Conversation
…droid C++ (react#59222) Summary: Two C++ files built into RN-Tester include public React Native headers directly instead of through their module umbrella, which is an `#error` under `RN_STRICT_API`: - `rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.cpp`, - `react/debug/react_native_assert.h`, - The checked-in codegen output of `react-native/popup-menu-android` (`Props.cpp`) included `react/renderer/core/PropsParserContext.h` and `propsConversions.h`. No behavior change; this prepares RN-Tester to build with `RN_STRICT_API` by default. Changelog: [Internal] Differential Revision: D126328619
Summary: Turn on the C++ stable API checks (`RN_STRICT_API`) in RN-Tester by default, so the opt-ins and React Native's app-facing headers are exercised in strict mode on every build: - Android: `strictCxxApiEnabled=true` in `android/app/gradle.properties`. - iOS (CocoaPods): the Podfile sets `RN_STRICT_API=1` unless the environment already sets it, so `pod install` applies it the same way an app would. Changelog: [Internal] Differential Revision: D126330702
Summary: Turn on the C++ stable API checks (`RN_STRICT_API`) in the template apps CI builds, so the opt-ins, React Native's app-facing headers and the generated codegen and autolinking code are compiled in strict mode the way a new app would build them: - `private/helloworld`: `strictCxxApiEnabled=true` in `android/gradle.properties`, and the Podfile sets `RN_STRICT_API=1` unless the environment already sets it (`RN_STRICT_API=0 pod install` opts out). - Community template CI (cloned at build time): `build-android-templateapp.yml` appends `strictCxxApiEnabled=true` to the generated app's `gradle.properties`, and `e2e-ios-templateapp.yml` runs its `pod install` with `RN_STRICT_API=1`. Changelog: [Internal] Differential Revision: D126330998
Summary: Run `spm add` with `RN_STRICT_API=1` in the three SwiftPM CI jobs (RN-Tester, helloworld and the new-app flow), so the SwiftPM opt-in is exercised the way an app enables it. `spm add` records the choice in `.spm-injected.json` and defines `RN_STRICT_API` for the app target, the `spm.modules` packages (RN-Tester's sample native modules) and the app's codegen package. This depends on the C++ stable API guards being `textual header` members of the prebuilt `ReactNativeHeaders` module map. Changelog: [Internal] Differential Revision: D126331456
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126331456. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Run
spm addwithRN_STRICT_API=1in the three SwiftPM CI jobs (RN-Tester, helloworld and the new-app flow), so the SwiftPM opt-in is exercised the way an app enables it.spm addrecords the choice in.spm-injected.jsonand definesRN_STRICT_APIfor the app target, thespm.modulespackages (RN-Tester's sample native modules) and the app's codegen package.This depends on the C++ stable API guards being
textual headermembers of the prebuiltReactNativeHeadersmodule map.Changelog: [Internal]
Differential Revision: D126331456