Repository navigation
CI: Prepare the native-image notebook E2E job for the fork's GitHub Packages (#251) - #252
Merged
Merged
Conversation
…ackages The notebook-e2e fixture reads the fork's modules from a Maven URL as well as mavenLocal (composeExtended.repository, credentials from GITHUB_ACTOR/GITHUB_TOKEN). desktop.yml gets a notebook-e2e-native-image job, skipped until the repository variable COMPOSE_EXTENDED_VERSION names a published version. It uses the secret GH_PACKAGES_TOKEN when it exists and GITHUB_TOKEN otherwise, checks one POM first and fails naming the secret when the packages cannot be read, then records the configuration, builds the image and runs it. Refs #251
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #251. This PR does not close it: the job cannot run until the fork publishes.
Feature added:
notebook-e2efixture can read the fork's modules from a Maven URL (composeExtended.repository), as well as from mavenLocal.GITHUB_ACTOR/GITHUB_TOKENcredentials when they are set: GitHub Packages asks for a token even for a public package.desktop.ymlgets anotebook-e2e-native-imagejob (macOS, Liberica NIK 25 viagraalvm/setup-graalvm,permissions: packages: read).COMPOSE_EXTENDED_VERSIONis set, so develop stays green before the fork publishes.COMPOSE_EXTENDED_GROUP_PREFIX(defaultorg.thisisthepy.compose) andCOMPOSE_EXTENDED_REPOSITORY(default the core fork's GitHub Packages URL).GH_PACKAGES_TOKENwhen it exists, elseGITHUB_TOKEN.read:packagesPAT asGH_PACKAGES_TOKEN.Not verified: whether
GITHUB_TOKENcan read the fork's packages. GitHub documents the Maven registry as repository-scoped only, so there is no per-package "Manage Actions access" for it; whether another repository's token reads a public package is not stated. The access check will say which on the first run.Local check: the mavenLocal path still resolves the fork's
1.11.1001. The remote path is consulted, and fails today because nothing is published yet.