Add contextMenuHidden to TextInput by amhinson · Pull Request #16847 · react/react-native

amhinson · 2017-11-15T21:36:07Z

Motivation

There is currently no way to disable to tooltip that automatically appears over a TextInput. This is especially troublesome if you would like to disable the user from pasting text into certain fields. This PR adds a tooltipHidden property to TextInput that will hide it.

Test Plan

I'm not sure if testing is necessary here. I would be happy to investigate further on how this would be tested, if deemed necessary!

Release Notes

[FEATURE][TextInput] - Added tooltipHidden property

pull-bot · 2017-11-15T21:37:26Z

@facebook-github-bot label Android

Attention: @shergin

Generated by 🚫 dangerJS

Reviewed By: gkassabli Differential Revision: D6297015 fbshipit-source-id: 6a67bdf33ef121785ac14938f5d3ed6e9d6f2656

Reviewed By: javache Differential Revision: D6316024 fbshipit-source-id: c1b315fac2c3cf8558d0c9eb0eb2c7d3efe5c64f

Summary: I'm loving `react-native-git-upgrade`, such a life and time saver, but when doing the upgrade, if git hooks are defined globally to be applied, `react-native-git-upgrade` uses these git hooks, although they might not be relevant to the upgrade process (and potentially make it way longer). Btw, thanks ncuillery for the great tool 😄 To test, I : * cloned my project * upgraded it with the npm published `react-native-git-upgrade` version : Git hooks are running during the upgrade * cloned the `react-native` repo * did my modifications on the `react-native-git-upgrade/cliEntry.js` file * `npm i -g react-native-git-upgrade/` after running `yarn` in that folder * Re-cloned my project in another folder * Upgraded it with `react-native-git-upgrade` : The hooks are not running anymore, yay! [CLI] [ENHANCEMENT] [react-native/react-native-git-upgrade] - Do not run git hooks in the upgrade process I plan to add an option to the cli so you can pass `--verify` or `--use-git-hooks` if you DO want your git hooks to run, but don't have the time right now and I think the default should be to not run them. Closes react#16855 Differential Revision: D6353781 Pulled By: hramos fbshipit-source-id: e4b0f55d10c37bc805b32cb4c0fe3c863346482d

Summary: Now that the Component and API docs are no longer auto-generated, we need to consolidate on a new format for our jsdoc comments. Any help from the community will be appreciated. In this initial pull request, we'll be tackling the following docs: - `AccessibilityInfo`, an API doc. - `ActivityIndicator`, a Component doc. - `View`, a Component doc. This top comment will serve as a style guide, and when in doubt, please refer to the individual commits in this PR. Each commit should update a single component or API, along with any relevant markdown files. - Documentation in the JavaScript source files should be succinct. Any verbosity should be moved over to the markdown docs in the website... - ...by adding a link to the relevant method/prop on the website to every comment block. - Avoid markdown style links in JavaScript source files, opt for plain old URIs. Let code document itself: - If a method is Flow typed, the comment block does not need to repeat this information. - If a param can be one of several values, and the type definition is easily determined from the code, the values should not be repeated in the comment block. Again, move this to the markdown doc if not present already. Closes react#16790 Differential Revision: D6353840 Pulled By: hramos fbshipit-source-id: 9712c459acc33092aae9909f3dd0b58a00b26afc

Summary: Android tests on CI have been failing since late October due to dd016f3 which makes use of a new Buck feature, `required_for_source_only_abi`. Circle was using an older September release. In this PR, we update to the latest release. Green is good. Red is bad. Wait for Circle to run. [INTERNAL][BUGFIX][./circleci/config.yml] - Update Buck version Closes react#16861 Differential Revision: D6355335 Pulled By: hramos fbshipit-source-id: 411d0b229f0dfb7e9dfc07c300b6546bf7afcdfe

Reviewed By: sahrens Differential Revision: D6350352 fbshipit-source-id: e909600875156127eb3144726981ab62e0015e6e

…ase of error Differential Revision: D6347967 fbshipit-source-id: 88788da321ca75d20b6c1a8e3d41642af7c6155e

Reviewed By: davidaurelio Differential Revision: D6338677 fbshipit-source-id: 8fa8f618bf8d6cb2291ce4405093cad23bd47fc3

Reviewed By: achen1 Differential Revision: D6341419 fbshipit-source-id: e49188803bbf3641bad6a9cc8c497d453798bbce

Reviewed By: sahrens Differential Revision: D6339469 fbshipit-source-id: d832de936c50edcdc6953b72b5ad18ce1b652187

Summary: Improve the error message shown when you try to nest components in an `<Image>` component by referencing the `<ImageBackground>` component. It would be helpful if the error message displayed when you try to nest components in an `<Image>` component mentioned the `<ImageBackground>` component. Especially since this component is not yet well documented. [IOS][MINOR][Libraries/Image/Image.ios.js] - Surfaced `<ImageBackground>` in error message [ANDROID][MINOR][Libraries/Image/Image.android.js] - Surfaced `<ImageBackground>` in error message Closes react#16880 Differential Revision: D6369396 Pulled By: shergin fbshipit-source-id: c4ae4dbb77d0fce6cbd7a42d1957d16112b24549

Summary: Correcting the redirection link to the right section ID for ListFooterComponent.  (Making the site flow better.) (Just fixed a small typo!)  Closes react#16873 Differential Revision: D6370785 Pulled By: hramos fbshipit-source-id: bb6e5ca4e9bb585f94670c233258d602136e3097

Summary: Prop for SectionList 'ItemSeperatorComponent' was repeated twice.  (Write your motivation here.) (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)  Closes react#16872 Differential Revision: D6370787 Pulled By: hramos fbshipit-source-id: f5b53376b6c169d96089e8706612587cc50d8669

Summary: `.sort()` will sort on the string value by default, so if you generate [18, 8], they will stay in that order. Adding comparer to ensure values are sorted numerically. Found a bug in RNTester. Ran RNTester and confirmed that bug could be reproduced. [IOS][BUGFIX][RNTester] - patch test to implement desired behavior. Closes react#16871 Differential Revision: D6371550 Pulled By: shergin fbshipit-source-id: 84866d1eb02c2be51cd15a60490604d28fa18973

Summary: I was confused by the current documentation, as it was requesting me to pass the previously received `end_cursor` into the next fetch but it was declared as a boolean. I checked in the debugger and it's just mislabeled in the docs, so this PR fixes the docs. I tried to push this change back in react#15472 but wasn't able to undo the borked rebase, so I'm submitting a new PR. This is a change to documentation only. [DOCS] [BUGFIX] [Libraries/CameralRoll/CameraRoll.js] - Corrected return type in the documentation for the `start_cursor` and `end_cursor` values. Closes react#16830 Differential Revision: D6371585 Pulled By: hramos fbshipit-source-id: 5038041e95a04ea4c2de8d2b535a8a4e019289f6

Reviewed By: fromcelticpark Differential Revision: D6373275 fbshipit-source-id: c36b53f023800097b301d530250b05e5b2a4dfca

Reviewed By: mjesun Differential Revision: D6374111 fbshipit-source-id: f372242ddbb8a278041d1ebb2aace227a571c2e0

Summary: [DOCS] Closes react#16874 Differential Revision: D6375515 Pulled By: hramos fbshipit-source-id: 64359b45a37c7b478919121573ca04dbb1ce6609

Summary: Follow up from [this comment](react@1b22d49#commitcomment-25699227). Closes react#16892 Differential Revision: D6374118 Pulled By: bvaughn fbshipit-source-id: e692985d6736986acc073fa036d413121ce51f41

Reviewed By: fromcelticpark Differential Revision: D6361741 fbshipit-source-id: 96e92dff5dd3d7aa1f7555442b0eba90e7dbf47c

Reviewed By: fromcelticpark Differential Revision: D6370566 fbshipit-source-id: fe59a789113c2e8c24e96e560647efbd8bdfe67b

Reviewed By: emilsjolander Differential Revision: D6374147 fbshipit-source-id: 8c896dce23571268a1a52df5cc72486af9d66df7

shergin · 2017-11-21T18:11:12Z

My conserns:

This thing is called context menu, not tooltip;
I don't think that turning off all context menu actions is a good idea, we have to have more granular control of those features;
We have to avoid "Negative logic" in naming things;
We also have to implement it for multiline ;
And for Android as well.

Summary: Quick fix Closes react#16910 Differential Revision: D6385891 Pulled By: hramos fbshipit-source-id: 5fcb0674db14282ccac5aa26518a84888a5e3005

Reviewed By: gkassabli Differential Revision: D6271299 fbshipit-source-id: 66c0e54ccf019d72d1fd0b4d117826e4e84fdc89

amhinson · 2017-11-21T18:29:25Z

@shergin Thanks for looking it over. Do you have any thoughts on how we can add more granular control?

Reviewed By: adamjernst Differential Revision: D6618153 fbshipit-source-id: 188e2ca3cc78efad6e71f0a22547e26abf2f62e1

Reviewed By: fromcelticpark Differential Revision: D6502049 fbshipit-source-id: 31a611cea4c017877c3ce2f7e9a3503723af4c2d

Summary: This PR fixes the problem with dev loading view on KitKat and older Android devices after react#16596 Install RNTester app on Android API 19 or lower device. See green loading view show up under status bar. Do the same with full screen theme set and see it show up correctly at the top of the screen. Verify the green loading bar displays correctly on devices with API > 19 too. This fixes an issue introduced in react#16596 [ANDROID][MINOR][DevSupport] - Fix green dev loading bar on Android Kitkat and below Closes react#17305 Differential Revision: D6621077 Pulled By: achen1 fbshipit-source-id: 3b4216af535d7db5c96d137f20004fe2651b1dc9

Summary: Test Plan Rebuilt Docker images locally, confirmed successful image build. Can later be reproed with ``` npm run test-android-setup npm run test-android-build npm run test-android-run-unit-tests ``` Note that unit tests are failing in master, but in this PR we can repro the same failure. Closes react#17313 Differential Revision: D6624899 Pulled By: hramos fbshipit-source-id: 42b8cd708ec2a02399bb6ef30fd73faba2646f79

Summary: Setting `windowSize = 0` doesn't make sense. Let's make sure we catch this problem in the constructor so that it doesn't cause inexplicable list behavior. Also fixed an invariant in `VirtualizeUtils` that is meant to prohibit non-monotonically-increasing offset arrays. As written, the invariant condition can never actually be violated. Reviewed By: sahrens Differential Revision: D6625302 fbshipit-source-id: b2a983cbe7bb5fbe0aed7c5d59e69a8a00672993

Reviewed By: emilsjolander Differential Revision: D6619293 fbshipit-source-id: c1632efd97f47696b7f8bb1b3e763de92c707287

Reviewed By: hramos Differential Revision: D6626785 fbshipit-source-id: bb7c89499bc7c72e24dabd82899c3d9c49874101

Summary: See react#17234 for discussion. Closes react#17310 Differential Revision: D6627914 Pulled By: hramos fbshipit-source-id: 3d72fc69fe03c53706d2076ecf7b5321a00d1642

Summary: WIP. Closes react#17295 Differential Revision: D6628523 Pulled By: hramos fbshipit-source-id: ac2833e99de9e94340b8027469cc74a5b7379962

Reviewed By: ttsugriy Differential Revision: D6630280 fbshipit-source-id: 6355d4b64a39feb000d5a104f39733a90fc5a31e

Summary: android-setup.html does not seem to exist. https://facebook.github.io/react-native/docs/android-setup.html (404) Closes react#17324 Differential Revision: D6630732 Pulled By: hramos fbshipit-source-id: c1bd4750e3b72a0b1542a75f50d404807eabb8f1

Summary:  (Write your motivation here.) (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!) (If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.)  Closes react#17326 Differential Revision: D6630825 Pulled By: hramos fbshipit-source-id: f2c0369e3dc5b279aba96c8307b742693be1494c

Summary: Use newer Docker image and add script that rebuilds the image locally Rebuilding should be rarely needed, but in this case we did need a newer BUCK version To run tests locally: ``` npm run test-android-setup npm run test-android-build npm run test-android-run-unit-test ``` If a newer android-base image is needed, just run `npm run test-android-build-base` to rebuild the image locally. Ping hramos if the Docker hub image is too out of date. Closes react#17325 Differential Revision: D6630793 Pulled By: hramos fbshipit-source-id: ec76ec86aec0debf914649b7ec5fdafccf28fec7

Reviewed By: davidaurelio Differential Revision: D6633160 fbshipit-source-id: ce45cae413959c232cb18b4b5ad51f04a52410a4

facebook-github-bot · 2017-12-23T18:04:18Z

@amhinson I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

amhinson · 2017-12-23T23:21:50Z

@facebook-github-bot Yes, this PR is still relevant. Just rebased.

…mhinson/react-native into add-tooltiphidden-to-textinput

pull-bot · 2017-12-23T23:28:04Z

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️	❗ Big PR - This PR is extremely unlikely to get reviewed because it touches 60028 lines.
⚠️	❗ Bots - This PR appears to modify the list of people that may issue commands to the GitHub bot.

@facebook-github-bot label Android

@facebook-github-bot large-pr

Attention: @janicduplessis, @shergin, @mhorowitz, @hramos, @grabbou, @Kureev

Generated by 🚫 dangerJS

amhinson · 2017-12-23T23:45:55Z

Closing this to create a new clean PR. #17335

AKKIDETROJA · 2019-04-04T06:14:32Z

<TextInput
   contextMenuHidden={true}
  value={this.state.text}
onChangeText={(text) => this.setState({ text})}
/>

Add tooltip hidden to TextInput for iOS

167a5c1

amhinson requested a review from shergin as a code owner November 15, 2017 21:36

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 15, 2017

priteshrnandgaonkar and others added 22 commits November 16, 2017 05:34

Replace printf with YGLog calls

6c70975

Reviewed By: gkassabli Differential Revision: D6297015 fbshipit-source-id: 6a67bdf33ef121785ac14938f5d3ed6e9d6f2656

Unify Systrace native hook argument passing.

52e3ae9

Reviewed By: javache Differential Revision: D6316024 fbshipit-source-id: c1b315fac2c3cf8558d0c9eb0eb2c7d3efe5c64f

Fix minimumViewTime in ViewabilityHelper

d19d137

Reviewed By: sahrens Differential Revision: D6350352 fbshipit-source-id: e909600875156127eb3144726981ab62e0015e6e

Make RCTNativeModule::invokeInner explicitely return folly::none in c…

0ac5a52

…ase of error Differential Revision: D6347967 fbshipit-source-id: 88788da321ca75d20b6c1a8e3d41642af7c6155e

Add end to end Delta support to Android devices

231c7a0

Reviewed By: davidaurelio Differential Revision: D6338677 fbshipit-source-id: 8fa8f618bf8d6cb2291ce4405093cad23bd47fc3

check if listener is still in the set before calling onHostResume

ad89ea7

Reviewed By: achen1 Differential Revision: D6341419 fbshipit-source-id: e49188803bbf3641bad6a9cc8c497d453798bbce

renderApplication() supports async initial render

1b22d49

Reviewed By: sahrens Differential Revision: D6339469 fbshipit-source-id: d832de936c50edcdc6953b72b5ad18ce1b652187

Fix crash when destroying catalyst

f101566

Reviewed By: fromcelticpark Differential Revision: D6373275 fbshipit-source-id: c36b53f023800097b301d530250b05e5b2a4dfca

Enable end to end deltas by default on Android

f587f8d

Reviewed By: mjesun Differential Revision: D6374111 fbshipit-source-id: f372242ddbb8a278041d1ebb2aace227a571c2e0

Migrate additional docs to the new format

79e24ed

Summary: [DOCS] Closes react#16874 Differential Revision: D6375515 Pulled By: hramos fbshipit-source-id: 64359b45a37c7b478919121573ca04dbb1ce6609

Replace fburl.com link with public fb.me link

c91d872

Summary: Follow up from [this comment](react@1b22d49#commitcomment-25699227). Closes react#16892 Differential Revision: D6374118 Pulled By: bvaughn fbshipit-source-id: e692985d6736986acc073fa036d413121ce51f41

Make RCTPackagerConnection a singleton

9180d4e

Reviewed By: fromcelticpark Differential Revision: D6361741 fbshipit-source-id: 96e92dff5dd3d7aa1f7555442b0eba90e7dbf47c

RCTRedBox should appear beneath the status bar

33cefc1

Reviewed By: fromcelticpark Differential Revision: D6370566 fbshipit-source-id: fe59a789113c2e8c24e96e560647efbd8bdfe67b

Deleted YGSetMemoryFucs as it is unused

d950dc6

Reviewed By: emilsjolander Differential Revision: D6374147 fbshipit-source-id: 8c896dce23571268a1a52df5cc72486af9d66df7

hramos and others added 2 commits November 21, 2017 10:18

Fix Shadow Props

3c9092a

Summary: Quick fix Closes react#16910 Differential Revision: D6385891 Pulled By: hramos fbshipit-source-id: 5fcb0674db14282ccac5aa26518a84888a5e3005

Change c files to cpp

d7ab949

Reviewed By: gkassabli Differential Revision: D6271299 fbshipit-source-id: 66c0e54ccf019d72d1fd0b4d117826e4e84fdc89

ttsugriy and others added 14 commits December 21, 2017 08:58

Replace native cxx_library with fb-specific macros.

ba31d29

Reviewed By: adamjernst Differential Revision: D6618153 fbshipit-source-id: 188e2ca3cc78efad6e71f0a22547e26abf2f62e1

remove embeddedBundleURL

489b98b

Reviewed By: fromcelticpark Differential Revision: D6502049 fbshipit-source-id: 31a611cea4c017877c3ce2f7e9a3503723af4c2d

Optimize the performance of Origami

a163f70

Reviewed By: emilsjolander Differential Revision: D6619293 fbshipit-source-id: c1632efd97f47696b7f8bb1b3e763de92c707287

Define internal FB macro for OSS builds.

077c3ab

Reviewed By: hramos Differential Revision: D6626785 fbshipit-source-id: bb7c89499bc7c72e24dabd82899c3d9c49874101

Update to Danger 2.0

b750e3b

Summary: See react#17234 for discussion. Closes react#17310 Differential Revision: D6627914 Pulled By: hramos fbshipit-source-id: 3d72fc69fe03c53706d2076ecf7b5321a00d1642

Fix buck failures on master

4e76701

Summary: WIP. Closes react#17295 Differential Revision: D6628523 Pulled By: hramos fbshipit-source-id: ac2833e99de9e94340b8027469cc74a5b7379962

Include OSS defs in Yoga BUCK

33da604

Reviewed By: ttsugriy Differential Revision: D6630280 fbshipit-source-id: 6355d4b64a39feb000d5a104f39733a90fc5a31e

use working getting started url

6661633

Summary: android-setup.html does not seem to exist. https://facebook.github.io/react-native/docs/android-setup.html (404) Closes react#17324 Differential Revision: D6630732 Pulled By: hramos fbshipit-source-id: c1bd4750e3b72a0b1542a75f50d404807eabb8f1

Do not set minify=true when calculating the list of dependencies

4a1bb8f

Reviewed By: davidaurelio Differential Revision: D6633160 fbshipit-source-id: ce45cae413959c232cb18b4b5ad51f04a52410a4

AirshipAlex added 5 commits December 23, 2017 17:26

Add tooltip hidden to TextInput for iOS

85c1962

Change to context menu & add Android support

03ae100

Add contextMenuHidden for multiline TextInput

03d1e31

Remove added whitespace

eaabf99

Merge branch 'add-tooltiphidden-to-textinput' of https://github.com/a…

a9892a5

…mhinson/react-native into add-tooltiphidden-to-textinput

amhinson requested review from Kureev, grabbou, hramos, janicduplessis and mhorowitz as code owners December 23, 2017 23:27

amhinson closed this Dec 23, 2017

Navigation Menu

Repository navigation

Add contextMenuHidden to TextInput - #16847

Add contextMenuHidden to TextInput#16847
amhinson wants to merge 234 commits into
react:masterfrom
amhinson:add-tooltiphidden-to-textinput

amhinson commented Nov 15, 2017 •

edited

Loading

Uh oh!

pull-bot commented Nov 15, 2017 •

edited

Loading

Uh oh!

shergin commented Nov 21, 2017

Uh oh!

amhinson commented Nov 21, 2017 •

edited

Loading

Uh oh!

facebook-github-bot commented Dec 23, 2017

Uh oh!

amhinson commented Dec 23, 2017

Uh oh!

pull-bot commented Dec 23, 2017

Uh oh!

amhinson commented Dec 23, 2017 •

edited

Loading

Uh oh!

AKKIDETROJA commented Apr 4, 2019 •

edited

Loading

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

amhinson commented Nov 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Test Plan

Release Notes

Uh oh!

pull-bot commented Nov 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shergin commented Nov 21, 2017

Uh oh!

amhinson commented Nov 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Dec 23, 2017

Uh oh!

amhinson commented Dec 23, 2017

Uh oh!

pull-bot commented Dec 23, 2017

Uh oh!

amhinson commented Dec 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AKKIDETROJA commented Apr 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

amhinson commented Nov 15, 2017 •

edited

Loading

pull-bot commented Nov 15, 2017 •

edited

Loading

amhinson commented Nov 21, 2017 •

edited

Loading

amhinson commented Dec 23, 2017 •

edited

Loading

AKKIDETROJA commented Apr 4, 2019 •

edited

Loading